Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove almost all cspell:ignore #3599

Merged
merged 6 commits into from
Aug 17, 2024
Merged

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Aug 16, 2024

This PR removes almost all cspell:ignore on top of script files.

Notes:

  • Excluded ./packages/client/archive for cspell. Once we reuse it, it will automatically get into the spell check pool
  • Did not remove cspell:ignore in wallet, because I don't know what those values mean, and I don't want to touch the wallet code

TODO

  • I realized that there might be // cspell comments into the docs of methods/classes, this will thus also end up in the end doc. Need to figure out how to fix this, since wrapping the entire comment in cspell:disable an then cspell:enable will effectively disable the spell check for those docs which is not what we want.

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (cspell@dd1f2ff). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
blockchain 84.92% <ø> (?)
devp2p 0.00% <0.00%> (?)
util 69.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer jochem-brouwer marked this pull request as ready for review August 17, 2024 12:22
@jochem-brouwer jochem-brouwer merged commit 5167780 into cspell Aug 17, 2024
35 checks passed
@jochem-brouwer jochem-brouwer deleted the fix-spelling-mistakes-ignore branch August 17, 2024 12:27
jochem-brouwer added a commit that referenced this pull request Aug 17, 2024
* monorepo: add cspell, add ALL unknown words to valid words

* cspell: split unknown words in ts/md

* filter out wrong words in cspell-ts.json

* cspell ignore hex values

* fix typos in all packages

* cspell: use cache

* cspell: update commands

* cspell: update md/ts words

* Typo fixes for README/CHANGELOG files

* cspell: ensure all relevant monorepo md files are checked

* ci: add cspell job

* cspell: update command

* temp add bogus to markdown

* remove bogus spell

* update ci name

* fix remaining typos + add words to cspell dict

* Update packages/client/CHANGELOG.md

* Update packages/util/CHANGELOG.md

* address review

* Remove almost all `cspell:ignore` (#3599)

* remove almost all cspell:ignore

* more spell changes

* cspell: fix problems

* evm: fix quadCoefficient

* cspell: fixes

* remove disable line

---------

Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
holgerd77 pushed a commit that referenced this pull request Aug 19, 2024
* monorepo: add cspell, add ALL unknown words to valid words

* cspell: split unknown words in ts/md

* filter out wrong words in cspell-ts.json

* cspell ignore hex values

* fix typos in all packages

* cspell: use cache

* cspell: update commands

* cspell: update md/ts words

* Typo fixes for README/CHANGELOG files

* cspell: ensure all relevant monorepo md files are checked

* ci: add cspell job

* cspell: update command

* temp add bogus to markdown

* remove bogus spell

* update ci name

* fix remaining typos + add words to cspell dict

* Update packages/client/CHANGELOG.md

* Update packages/util/CHANGELOG.md

* address review

* Remove almost all `cspell:ignore` (#3599)

* remove almost all cspell:ignore

* more spell changes

* cspell: fix problems

* evm: fix quadCoefficient

* cspell: fixes

* remove disable line

---------

Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
@@ -8,7 +8,7 @@
"checkNpmVersion": "./scripts/check-npm-version.sh",
"clean": "./config/cli/clean-root.sh",
"cspell": "npm run cspell:ts && npm run cspell:md",
"cspell:ts": "npx cspell --gitignore -e \"./packages/ethereum-tests\" -e \"./packages/wallet/test\" -c ./config/cspell-ts.json \"./packages/**/*.ts\" --cache --show-suggestions --show-context",
"cspell:ts": "npx cspell --gitignore -e \"./packages/ethereum-tests\" -e \"./packages/wallet/test\" -e \"./packages/client/archive\" -c ./config/cspell-ts.json \"./packages/**/*.ts\" --cache --show-suggestions --show-context",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can't more of these options put in the configuration file so that we can keep it simpler here?

holgerd77 added a commit that referenced this pull request Aug 19, 2024
…Code put() Fix, VerkleSM out, runTx()+Code Opts) (#3601)

* Use shallowCopy() Caches copy() optimization also for VerkleSM to avoid Caches bundling on non-Caches default

* Fix default state manager missing direct code write when used without caches

* Do not initialize caches for default VM state manager

* Remove copy test not making sense any more under generalized cache/no-cache conditions

* Some more solid/qualified EVM dummy blockchain + interface naming to allow for exporting

* Use EVMMockBlockchain(Interface) as default for the VM, adjust some tests

* Move @ethereumjs/blockchain to dev dependencies in VM

* Rebuild package-lock.json

* Adjust/fix some client tests

* Lint fix

* Add Verkle SM methods as optional methods to interface, replace VerkleSM imports and castings in VM

* Also align client (no real effect yet, but generally try to work more on the interfaces and not the classes directly)

* Initialize runTx() default block with simpler constructor to avoid drawing all txs in

* Fully switch to DEFAULT_HEADER in VM.runTx() to avoid drawing in block code

* Opcode list size optimization

* More optimizations

* Precompile code optimizations

* More optimizations (precompile index.ts file)

* Some more

* Some doc compatification

* Add CSpell checker to CI and fix typos (#3590)

* monorepo: add cspell, add ALL unknown words to valid words

* cspell: split unknown words in ts/md

* filter out wrong words in cspell-ts.json

* cspell ignore hex values

* fix typos in all packages

* cspell: use cache

* cspell: update commands

* cspell: update md/ts words

* Typo fixes for README/CHANGELOG files

* cspell: ensure all relevant monorepo md files are checked

* ci: add cspell job

* cspell: update command

* temp add bogus to markdown

* remove bogus spell

* update ci name

* fix remaining typos + add words to cspell dict

* Update packages/client/CHANGELOG.md

* Update packages/util/CHANGELOG.md

* address review

* Remove almost all `cspell:ignore` (#3599)

* remove almost all cspell:ignore

* more spell changes

* cspell: fix problems

* evm: fix quadCoefficient

* cspell: fixes

* remove disable line

---------

Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>

* Fix spell check

* Remove accidentally committed examples/test.ts file

---------

Co-authored-by: Jochem Brouwer <jochembrouwer96@gmail.com>
Co-authored-by: Gabriel Rocheleau <contact@rockwaterweb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants