vm: remove backfill of block hashes on 2935 activation #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
approved these changes
Jun 30, 2024
| @@ -524,28 +522,6 @@ export async function accumulateParentBlockHash( | |||
| } | |||
| await putBlockHash(this, parentHash, currentBlockNumber - BIGINT_1) | |||
There was a problem hiding this comment.
I think we can now remove this function, since it is only called once.
| // More than blocks activation to build, so we can ensure that we can also retrieve block 0 or block 1 hash at block 300 | ||
| const blocksToBuild = 300 | ||
| const blocksToBuild = 500 |
There was a problem hiding this comment.
Do we now need 500 blocks, or can we also "just" create a few blocks (say 5)? We only need to test that the last blockhash is put into the contract at fork activation time.
There was a problem hiding this comment.
yes the test tests various scenarios of blockhash as well as the contract code windows as well as activation time
|
Short note: there is a nice type label |
This was referenced Sep 5, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the backfill of the last 256 hashes as it is already removed from the eip following kenya discussions