Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move over verkleCrypto handling into common #3774

Closed
gabrocheleau opened this issue Oct 28, 2024 · 1 comment · Fixed by #3790
Closed

Move over verkleCrypto handling into common #3774

gabrocheleau opened this issue Oct 28, 2024 · 1 comment · Fixed by #3790

Comments

@gabrocheleau
Copy link
Contributor

We currently are in a situation where we are passing verkleCrypto around in the VM/EVM/StateManager. With the latest AccessWitness work from #3770, we are now getting the verkleCrypto instantiation from stateManager, which is a bit roundabout and counterintuitive. As suggested by Holger in this comment: #3770 (comment), we could instead move it into Common.

@holgerd77
Copy link
Member

Ok, I think I remember that the main argument @acolytec3 had against this is that we would need Common to be added to the Verkle library. 🤔

Guess I am still somewhat in favor, might become necessary in the future along additional Verkle HFs anyhow and Common is in many cases already there and therefore also easily be used to carry this Verkle crypto around as we do with the other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants