You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently are in a situation where we are passing verkleCrypto around in the VM/EVM/StateManager. With the latest AccessWitness work from #3770, we are now getting the verkleCrypto instantiation from stateManager, which is a bit roundabout and counterintuitive. As suggested by Holger in this comment: #3770 (comment), we could instead move it into Common.
The text was updated successfully, but these errors were encountered:
Ok, I think I remember that the main argument @acolytec3 had against this is that we would need Common to be added to the Verkle library. 🤔
Guess I am still somewhat in favor, might become necessary in the future along additional Verkle HFs anyhow and Common is in many cases already there and therefore also easily be used to carry this Verkle crypto around as we do with the other stuff.
We currently are in a situation where we are passing
verkleCrypto
around in the VM/EVM/StateManager. With the latest AccessWitness work from #3770, we are now getting the verkleCrypto instantiation from stateManager, which is a bit roundabout and counterintuitive. As suggested by Holger in this comment: #3770 (comment), we could instead move it into Common.The text was updated successfully, but these errors were encountered: