Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Verkle instantiation easier #3763

Closed
acolytec3 opened this issue Oct 24, 2024 · 1 comment · Fixed by #3768
Closed

Make Verkle instantiation easier #3763

acolytec3 opened this issue Oct 24, 2024 · 1 comment · Fixed by #3768

Comments

@acolytec3
Copy link
Contributor

We have a few rough edges in how we initialize verkle trees at the moment. As long as you use the createVerkleTree constructor function, it's pretty straight forward. However, we should make a few changes:

  • Have the constructor default to instantiate a MapDB if none is provided
  • The _createRootNode function should be made public.
  • We should just get rid of the database function all together. There's no need for an independent DB setter/getter as this should be part of the constructor process
@acolytec3 acolytec3 self-assigned this Oct 24, 2024
@holgerd77 holgerd77 changed the title Make instantiation easier Make Verkle instantiation easier Oct 24, 2024
@gabrocheleau
Copy link
Contributor

Have some time this PM so will tackle this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants