Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx: Class names not fully consistent yet #3723

Open
holgerd77 opened this issue Oct 7, 2024 · 3 comments · May be fixed by #3733
Open

Tx: Class names not fully consistent yet #3723

holgerd77 opened this issue Oct 7, 2024 · 3 comments · May be fixed by #3733
Assignees
@jochem-brouwer
Labels
effort: E1 hours package: tx type: enhancement

Comments

@holgerd77
Copy link
Member

Following tx type class names still needs shortening from Transaction to Tx to be consistent with the other class names. 🙂

  • AccessList2930Transaction
  • EOACode7702Transaction

Correct example: FeeMarketEIP1559Transaction -> FeeMarket1559Tx
@jochem-brouwer
Copy link
Member

I will address this among the refactor PR(s). (Might break up the refactor in multiple PRs)

@jochem-brouwer
Copy link
Member

Ok, interesting how we missed this one, because you are right, for EIP1559 and for EIP4844 the names are correct 🤔

@holgerd77
Copy link
Member Author

It's super easy to miss out on these renamings, there is so much stuff all over the place

@jochem-brouwer jochem-brouwer linked a pull request Oct 9, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jochem-brouwer jochem-brouwer

Labels
effort: E1 hours package: tx type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TX refactor PR ethereumjs/ethereumjs-monorepo
2 participants
@holgerd77 @jochem-brouwer