Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ethereumjs/wallet integration TODO list #2731

Closed
8 of 9 tasks
acolytec3 opened this issue May 26, 2023 · 9 comments · Fixed by #2793
Closed
8 of 9 tasks

@ethereumjs/wallet integration TODO list #2731

acolytec3 opened this issue May 26, 2023 · 9 comments · Fixed by #2793

Comments

@acolytec3
Copy link
Contributor

acolytec3 commented May 26, 2023

@Coollaitar
Copy link
Contributor

Updated dependencies of ethereum-cryptography to v2.0.0 #2734

  • Update ethereum-cryptography dep to v2.0.0

@Coollaitar
Copy link
Contributor

Can you please elaborate in which files buffer should be replaced with Uint8Array?

@acolytec3
Copy link
Contributor Author

Can you please elaborate in which files buffer should be replaced with Uint8Array?

Anywhere buffers are used in this new package, they need to be placed with Uint8Arrays.

@Coollaitar
Copy link
Contributor

Can you please elaborate in which files buffer should be replaced with Uint8Array?

Anywhere buffers are used in this new package, they need to be placed with Uint8Arrays.

Okay, I will make a PR for that.

@Coollaitar
Copy link
Contributor

Updated dependencies of ethereum-cryptography to v2.0.0 #2737

  • Update ethereum-cryptography dep to v2.0.0

@gabrocheleau
Copy link
Contributor

Can this be closed @acolytec3 ? Seems like all todos have been completed.

@acolytec3
Copy link
Contributor Author

We should also clean up the conflicting types/node devDependency. I don't think there's any actual work other than removing the ones from wallet but we should do this so we don't have duplicate conflicting dependencies in our repo.

@gabrocheleau
Copy link
Contributor

We should also clean up the conflicting types/node devDependency. I don't think there's any actual work other than removing the ones from wallet but we should do this so we don't have duplicate conflicting dependencies in our repo.

So just this: #2793 ?

@acolytec3
Copy link
Contributor Author

We should also clean up the conflicting types/node devDependency. I don't think there's any actual work other than removing the ones from wallet but we should do this so we don't have duplicate conflicting dependencies in our repo.

So just this: #2793 ?

Yessir. I meant to submit this since I had done it locally. Will approve once CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants