Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

[🚜WIP] Custom config with custom logger #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rumkin
Copy link
Contributor

@rumkin rumkin commented Nov 3, 2020

🛑 THIS IS A DRAFT PR! Do not review it or merge! It conflicts with #176 which should be merged first.

This PR introduces custom config files for client from #171. It contains new CLI argument config which refers to custom configuration file.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #177 into master will decrease coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   74.66%   73.90%   -0.77%     
==========================================
  Files          45       40       -5     
  Lines        1508     1460      -48     
  Branches      199      194       -5     
==========================================
- Hits         1126     1079      -47     
+ Misses        322      318       -4     
- Partials       60       63       +3     
Impacted Files Coverage Δ
lib/rpc/validation.ts 80.95% <0.00%> (-8.24%) ⬇️
lib/logging.ts 71.42% <0.00%> (-6.35%) ⬇️
lib/rpc/modules/web3.ts 87.50% <0.00%> (-1.39%) ⬇️
lib/util/index.ts 100.00% <0.00%> (ø)
lib/rpc/error-code.ts 100.00% <0.00%> (ø)
lib/service/lightethereumservice.ts 100.00% <0.00%> (ø)
lib/net/protocol/index.ts
lib/net/peer/index.ts
lib/rpc/modules/index.ts
lib/sync/fetcher/index.ts
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238b499...6e41def. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant