testclient: setChainParams #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +33,29 @@ using namespace jsonrpc; | |||
|
|
|||
| Test::Test(eth::Client& _eth): m_eth(_eth) {} | |||
|
|
|||
| bool Test::test_setChainParams(const Json::Value ¶m1) | |||
There was a problem hiding this comment.
You mean should it belong to test section?
I think so. Normally node is started with either --genesis or --config section
This feature is experimental and for test purpose only.
There was a problem hiding this comment.
Oh sorry, somehow I thought this was a unit test...
Please move the const after the type.
| }, [&](Address const& _a) { return ICAP(_a).encoded() + " (" + _a.abridged() + ")"; } | ||
| ) + "\nEnter yes/no/always (always to this address): ", {"yes", "n", "N", "no", "NO", "always"}); | ||
| string r; | ||
| if (testingMode) |
There was a problem hiding this comment.
I think the following is both simpler and safer:
std::function<bool(TransactionSkeleton const&, bool)> authenticator;
if (testingMode)
authenticator = [](TransactionSkeleton const&, bool) -> bool { return true; }
else
authenticator = /* as it was before */
| if (testingMode) | ||
| authenticator = [](TransactionSkeleton const&, bool) -> bool { return true; }; | ||
| else | ||
| authenticator = [&](TransactionSkeleton const& _t, bool isProxy) -> bool { | ||
| // "unlockAccount" functionality is done in the AccountHolder. |
There was a problem hiding this comment.
This still has to be properly indented.
There was a problem hiding this comment.
you mean put it inside {} ?
There was a problem hiding this comment.
no, shift the body of the function one tab to the right.
|
Please merge after indenting the function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to ethereum/webthree-umbrella#542