Skip to content

Add topic to ContractEvent docs. #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Jan 22, 2025

What was wrong?

Closes #3556

How was it fixed?

ContractEvent docs now include the topic in the class attributes section.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

reedsa added a commit to reedsa/web3.py that referenced this pull request Jan 22, 2025
@reedsa reedsa requested review from fselmo, pacrob and kclowes January 22, 2025 17:46
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements for *ContractEvent and *ContractFunction APIs
3 participants