Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle None in the formatting middleware #2996

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

reedsa
Copy link
Contributor

@reedsa reedsa commented Jun 15, 2023

What was wrong?

Closes #2546

How was it fixed?

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@reedsa reedsa force-pushed the 2546-formatter-handle-none branch 2 times, most recently from 1dcc261 to 65d168a Compare June 20, 2023 15:05
@reedsa reedsa changed the title Initial tests for formatting middlewares Handle None in the formatting middleware Jun 20, 2023
@reedsa reedsa force-pushed the 2546-formatter-handle-none branch from 65d168a to 973ea10 Compare June 20, 2023 15:09
@reedsa reedsa marked this pull request as ready for review June 20, 2023 15:41
Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌🏼 ... though it's missing a cute animal picture 😱


edit: 🐘👌🏼

@reedsa reedsa merged commit 12f3702 into ethereum:main Jun 22, 2023
@reedsa reedsa deleted the 2546-formatter-handle-none branch June 22, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot convert None of type <class 'NoneType'> to bytes (in formatting middleware?)
4 participants