Adds Web3.toJSON per #782 #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Jan 8, 2019
| class Web3JsonEncoder(json.JSONEncoder): | ||
| def default(self, obj): | ||
| if isinstance(obj, AttributeDict): | ||
| return {k: v for k, v in obj.items()} |
There was a problem hiding this comment.
This seems like it should be a recursive operation, re-encoding each of the k and v values using json.JSONEncoder.default(self, v)
There was a problem hiding this comment.
Looks like json.JSONEncoder already handles recursion. default() just needs to provide one to one conversion. I added a test with a nested AttributeDict as verification.
|
Looks like there is also a linting error. See the CI failure for details. |
|
Think I addressed @pipermerriam's feedback and fixed the linting issues. Added simple docs as well. |
pipermerriam
approved these changes
Jan 9, 2019
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #782
How was it fixed?
Added
Web3.toJSON()and accompanying tests. Basically, this extends the standardjson.JSONEncoderto supportHexBytesandweb3.datastructures.AttributeDictand adds a static method to theWeb3object that utilizes it.This is my first PR for this project, so please tear it apart.
It would probably be good to get some more test cases, as well. In what other ways might a user use
Web3.toJSON()? Should there be more supported types? In what ways should it not work?Cute Animal Picture