Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ENS multicoin EIP-2304 #1839

Closed
vnavascues opened this issue Jan 19, 2021 · 2 comments · Fixed by #3030
Closed

Support ENS multicoin EIP-2304 #1839

vnavascues opened this issue Jan 19, 2021 · 2 comments · Fixed by #3030

Comments

@vnavascues
Copy link

vnavascues commented Jan 19, 2021

  • Version: 5.11.1
  • Python: 3.7
  • OS: osx/linux/win

ENS PublicResolver
EIP-2304

RESOLVER would require something like this:

  {
      "constant": True,
      "inputs": [
          {
              "name": "node",
              "type": "bytes32"
          },
          {
              "name": "coinType",
              "type": "uint256"
          },
      ],
      "name": "addr",
      "outputs": [
          {
              "name": "ret",
              "type": "bytes"
          }
      ],
      "payable": False,
      "type": "function"
  },

bruno.eth is an ENS domain with multiple coins set up.

By calling addr(bytes32, unit256) on its public resolver with:

  • bytes32: 0x9de0b76f3b87380f0bcb9e41b403c69b88b01fbeaf785e83f38a6879902af71b
  • uint256: 434

You should expect:

  • bytes: 0x0aff6865635ae11013a83835c019d44ec3f865145943f487ae82a8e7bed3a66b

Thanks

@vnavascues vnavascues changed the title Support ENS multicoin EIP-2034 Support ENS multicoin EIP-2304 Jan 19, 2021
@kclowes
Copy link
Collaborator

kclowes commented Jan 20, 2021

Thanks for raising this issue! I'm for it, but will probably take a bit for us to get to it. If you'd like this feature soon, feel free to open a PR and we'd be happy to review!

@vnavascues
Copy link
Author

Thanks for raising this issue! I'm for it, but will probably take a bit for us to get to it. If you'd like this feature soon, feel free to open a PR and we'd be happy to review!

Hi! No rush at least for me. If I find some time definitely I'll try to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants