Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs still mention UnhandledRequest but it's been removed #1737

Closed
mikeshultz opened this issue Sep 12, 2020 · 1 comment · Fixed by #1740
Closed

Docs still mention UnhandledRequest but it's been removed #1737

mikeshultz opened this issue Sep 12, 2020 · 1 comment · Fixed by #1740

Comments

@mikeshultz
Copy link
Contributor

What was wrong?

There are still two mentions of UnhandledRequest in the docs even though it appears to have been removed in #1166.

How can it be fixed?

A quick read of the PR suggests that it may now be CannotHandleRequest? I'm not entirely sure if it's a direct replacement so didn't put in a PR for the doc change.

@kclowes
Copy link
Collaborator

kclowes commented Sep 14, 2020

Yep, you're right. Without doing too much digging it looks to me like we just pass through whatever error comes from the provider, but docs definitely need to be changed. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants