Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByzantiumToConstantinopleFixAt5 transition does not check that it's actually a transition to Petersburg #644

Closed
veox opened this issue Oct 17, 2019 · 2 comments

Comments

@veox
Copy link

veox commented Oct 17, 2019

Fallout from ethereum/py-evm#1858 (review).

py-evm was erroneously transitioning to Constantinople, not Petersburg (a copy-paste error).

The test that checks the transition doesn't seem to have anything Petersburg-specific, so the test was still passing.

Not sure how to address this.

@winsvega
Copy link
Collaborator

winsvega commented Nov 3, 2019

You right. the initial test was done to see the difficulty bomb change from Byzantium to Constantinople
and the mining rewards + uncle rewards.

the solution is to add more sstore operations to this test

@qbzzt
Copy link
Collaborator

qbzzt commented Dec 5, 2020

Added in #768

@winsvega winsvega closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants