Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retesteth does not produce vm trace for some ValidBlock tests #1078

Closed
gurukamath opened this issue Sep 6, 2022 · 2 comments
Closed

retesteth does not produce vm trace for some ValidBlock tests #1078

gurukamath opened this issue Sep 6, 2022 · 2 comments

Comments

@gurukamath
Copy link

gurukamath commented Sep 6, 2022

I came across a handful of tests within the ValidBlocks folder that do not produce an evm trace with retesteth. I presume this is because these tests have invalid blocks in them. Is there any way of identifying such tests without running them through geth?

Also would it be more appropriate to have those tests in InvalidBlocks?

Example - test for the Berlin hard fork

@winsvega
Copy link
Collaborator

winsvega commented Sep 8, 2022

in that test trace is not retrived because imported block does not belong to the TOP difficulty chain, therefor thransaction is not found in the latest block.

actually vmtrace in blockchain tests not tested. it is implemented but never tested. see if other cases work.

I think I can fix it to look up for transaction in all known chains and print the vmtrace anyway. but does it make sense if chainreorg does no longer happen after Merge

@winsvega
Copy link
Collaborator

winsvega commented Feb 8, 2023

added more debug support for blockchain tests
including intermidiate statediffs and vmtrace for a specific transaction

https://ethereum-tests.readthedocs.io/en/latest/retesteth-ref.html#blockchain-test-debugging

@winsvega winsvega closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@winsvega @gurukamath and others