Skip to content

Add backwards compatibility to the generated soljson.js for solc-js <0.5.14 #7917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2019
Merged

Add backwards compatibility to the generated soljson.js for solc-js <0.5.14 #7917

merged 2 commits into from
Dec 9, 2019

Conversation

axic
Copy link
Member

@axic axic commented Dec 7, 2019 •
edited
Loading

Fixes #7927.

@axic axic mentioned this pull request Dec 9, 2019
Closed
@axic axic force-pushed the solc-backwards-compat branch from a6e0302 to 3a998da Compare December 9, 2019 13:08
@axic
Copy link
Member Author

axic commented Dec 9, 2019

Was wondering why the tests didn't fail, then realised there's also test/solcjsTests.sh where the branch has to be changed.

axic
axic commented Dec 9, 2019
View reviewed changes
scripts/travis-emscripten/build_emscripten.sh Outdated
@@ -94,6 +94,9 @@ make -j 4

cd ..
mkdir -p upload
# Patch soljson.js to provide backwards-compatibility with older emscripten versions
echo ";/* backwards compatibility */ Module['Runtime'] = Module;" >> $BUILD_DIR/libsolc/soljson.js
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was originally added in #5831 for 0.5.3, so we need to keep it til 0.6.0.

@axic axic force-pushed the solc-backwards-compat branch from 3a998da to b4a260d Compare December 9, 2019 13:18
@axic axic mentioned this pull request Dec 9, 2019
Merged
@axic axic marked this pull request as ready for review December 9, 2019 13:28
@chriseth chriseth merged commit e075b10 into develop Dec 9, 2019
@chriseth chriseth deleted the solc-backwards-compat branch December 9, 2019 13:41
@axic axic mentioned this pull request Dec 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

@ekpyron ekpyron Awaiting requested review from ekpyron

@leonardoalt leonardoalt Awaiting requested review from leonardoalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export Pointer_Stringify in solc-js
2 participants
@axic @chriseth