Skip to content

Add mention of docs testing to contribution docs #6257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

Add mention of docs testing to contribution docs #6257

merged 1 commit into from
Mar 13, 2019

Conversation

ChrisChinchilla
Copy link
Contributor

@ChrisChinchilla ChrisChinchilla commented Mar 13, 2019 •
edited
Loading

Description

Closing #4422 to mention that contributing docs does trigger tests, what those tests are, and how you can run them before submitting a PR.

Checklist

  • Code compiles correctly
  • All tests are passing
  • New tests have been created which fail without the change (if possible)
  • README / documentation was extended, if necessary
  • Changelog entry (if change is visible to the user)
  • Used meaningful commit messages

@chriseth chriseth merged commit 9c9053d into develop Mar 13, 2019
@axic axic deleted the docs-testing branch March 21, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisChinchilla @chriseth