New test setting types: enum list/enum set #16015
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
added
testing 🔨
has dependencies
cameel
force-pushed
the
enum-list-test-setting
branch
from
5bba037 to
6d69aad
Compare
cameel
force-pushed
the
refactor-soltest-error-handling
branch
from
fc66d33 to
0c1a327
Compare
cameel
force-pushed
the
refactor-soltest-error-handling
branch
from
0c1a327 to
caeaa48
Compare
cameel
force-pushed
the
enum-list-test-setting
branch
from
6d69aad to
94e28fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #16014.
A small quality-of-life improvement extracted from #16012. The PR is yet another case (after #15803) where a list setting would have been useful so I added one.
May also come in handy in #15819, though for that a list of ranges would be better.
The PR also adjusts the handling of the
outputssetting inObjectCompilerTestto be consistent with what the evmasm test case does (i.e. no hiding of empty ones).