Fix CLI --version test to use version from the binary not package.json
#626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
force-pushed
the
fix-version-test-dont-compare-with-package-json
branch
from
2134a08
to
529c2db
Compare
cameel
commented
May 19, 2022
|
|
||
| tape('CLI', function (t) { | ||
| t.test('--version', function (st) { | ||
| const spt = spawn(st, './solc.js --version'); | ||
| spt.stdout.match(RegExp(pkg.version + '(-[^a-zA-A0-9.+]+)?(\\+[^a-zA-Z0-9.-]+)?')); |
There was a problem hiding this comment.
This old regex actually seems very broken. Given that the string it's meant to match is something like 0.8.10+commit.fc410830.Emscripten.clang:
A-Ashould probably have beenA-Z.- The character groups should not be negated with
^. pkg.versioncontains dots, which are interpreted as any character, not literal dots.
I think that only reason this regex "worked" is that these broken parts are marked as optional (?) and the regex was not anchored with ^ and $. So really anything after the version was being accepted.
cameel
force-pushed
the
fix-version-test-dont-compare-with-package-json
branch
from
529c2db
to
e078067
Compare
ekpyron
approved these changes
Jun 10, 2022
cameel
force-pushed
the
fix-version-test-dont-compare-with-package-json
branch
from
e078067
to
9a16f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently tests in
cli.tsare hard-coded to require a binary with version matchingpackage.json. This not true in general and causes problems in #598.This PR changes the test to only require the output from
--versionto match the output ofversion()function in the binary. I also kept a modified version of the previous check as a sanity check - to match that the output actually looks like our version string.