Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add G1 and G2 point value check #117

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Add G1 and G2 point value check #117

merged 1 commit into from
Feb 22, 2021

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 21, 2021

What was wrong?

Ensure the value is less than the field modulus.

How was it fixed?

Add more checks.

Cute Animal Picture

🦍

@hwwhww hwwhww assigned CarlBeek and unassigned CarlBeek Feb 21, 2021
@hwwhww hwwhww requested a review from CarlBeek February 21, 2021 13:39
Copy link
Collaborator

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hwwhww hwwhww merged commit 2e63a97 into master Feb 22, 2021
@hwwhww hwwhww deleted the check_value_domain branch February 22, 2021 10:14
@hwwhww hwwhww mentioned this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants