clients/go-ethereum: Cancun support #761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Apr 25, 2023
| # apk del go git make gcc musl-dev linux-headers && \ | ||
| # rm -rf /go-ethereum && rm -rf /var/cache/apk/* | ||
|
|
||
| ## ---- |
There was a problem hiding this comment.
Wondering why you are adding these lines, since we already have the equivalent steps just above?
There was a problem hiding this comment.
This one makes it just a tiny bit easier to build from a git branch, instead of having to manually clone inside the folder, and having to checkout to switch branches to compile from a different source.
I've been going to the commit where this was removed and copying this excerpt to do my local testing, I just find it easier to test locally with this code.
There was a problem hiding this comment.
since we already have the equivalent steps just above?
Yeah, no the steps above execute within the ethereum/client-go container as a builder, and is not suitable if you want to clone some non-official repository. LGTM
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
…ereum#761) Related to the deprecation of the gRPC gateway: OffchainLabs/prysm#14089 Currently the `mix-with-tools.yaml` test was failing due to the keymanager being enabled: ``` == FINISHED SERVICE 'vc-2-nethermind-prysm' LOGS =================================== Caused by: An error occurred while waiting for all TCP and UDP ports to be open Caused by: Unsuccessful ports check for IP '172.16.0.34' and port spec '{privatePortSpec:0xc00091a0c0}', even after '240' retries with '500' milliseconds in between retries. Timeout '2m0s' has been reached Caused by: An error occurred while calling network address '172.16.0.34:5056' with port protocol 'TCP' and using time out '200ms' Caused by: dial tcp 172.16.0.34:5056: connect: connection refused Error encountered running Starlark code. ```
racytech
pushed a commit
to racytech/hive
that referenced
this pull request
Apr 4, 2025
🤖 I have created a release *beep* *boop* --- ## [4.3.0](ethpandaops/ethereum-package@4.2.0...4.3.0) (2024-09-23) ### Features * add prefunded accounts ([ethereum#752](ethpandaops/ethereum-package#752)) ([1be7efa](ethpandaops/ethereum-package@1be7efa)) * dora - show more infos about all peers on client pages ([ethereum#760](ethpandaops/ethereum-package#760)) ([c77d95f](ethpandaops/ethereum-package@c77d95f)) ### Bug Fixes * `metrics-host-allowlist` for Teku ([ethereum#765](ethpandaops/ethereum-package#765)) ([ad75fcc](ethpandaops/ethereum-package@ad75fcc)) * built in validator lifecycle test for assertoor ([ethereum#763](ethpandaops/ethereum-package#763)) ([6f868cc](ethpandaops/ethereum-package@6f868cc)) * explicitly set client contexts ([ethereum#755](ethpandaops/ethereum-package#755)) ([94dc531](ethpandaops/ethereum-package@94dc531)) * no default resource limits ([ethereum#768](ethpandaops/ethereum-package#768)) ([4c4831b](ethpandaops/ethereum-package@4c4831b)) * prysm gRPC removal - use http server instead for keymanager ([ethereum#761](ethpandaops/ethereum-package#761)) ([ba91174](ethpandaops/ethereum-package@ba91174)) * remove epoch checker for goomy ([ethereum#754](ethpandaops/ethereum-package#754)) ([f124bbf](ethpandaops/ethereum-package@f124bbf)) * remove exp RPC API namespace flag from nimbus-eth1 configuration ([ethereum#767](ethpandaops/ethereum-package#767)) ([8fec454](ethpandaops/ethereum-package@8fec454)) * reth-builder volume claim ([ethereum#771](ethpandaops/ethereum-package#771)) ([4570328](ethpandaops/ethereum-package@4570328)) * update dora config for latest release & remove custom images ([ethereum#748](ethpandaops/ethereum-package#748)) ([a433c50](ethpandaops/ethereum-package@a433c50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
HIVE_CANCUN_TIMESTAMPenvironment variable.Also add commented lines for building from git in the Dockerfile.