simulators/ethereum/engine: Fix Geth Node Closing #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

marioevz merged 3 commits into ethereum:master from marioevz:engine-fix-node

Apr 7, 2023

Member

marioevz commented Apr 7, 2023

Changes Included

Properly unsubscribe from events so the Geth node can close
Close secondary clients that were never added to the CLMocker

marioevz added 3 commits

April 7, 2023 11:38


          simulators/ethereum/engine: node: unsubscribe from events

1a7a76f


          simulators/ethereum/engine: clmock: add extra logs

309cd56


          simulators/ethereum/engine: correctly stop secondary clients

c567845

Member Author

marioevz commented Apr 7, 2023

Ran entire set of ethereum/engine simulator tests, and they are all passing. Merging.

@fjl we might need to update the hivetests.

marioevz merged commit f2c72be into ethereum:master

racytech pushed a commit to racytech/hive that referenced this pull request


          fix: remove epoch checker for goomy (ethereum#754)

f124bbf

racytech pushed a commit to racytech/hive that referenced this pull request


          chore(main): release 4.3.0 (ethereum#749)

ec278db

🤖 I have created a release *beep* *boop*
---


##
[4.3.0](ethpandaops/ethereum-package@4.2.0...4.3.0)
(2024-09-23)


### Features

* add prefunded accounts
([ethereum#752](ethpandaops/ethereum-package#752))
([1be7efa](ethpandaops/ethereum-package@1be7efa))
* dora - show more infos about all peers on client pages
([ethereum#760](ethpandaops/ethereum-package#760))
([c77d95f](ethpandaops/ethereum-package@c77d95f))


### Bug Fixes

* `metrics-host-allowlist` for Teku
([ethereum#765](ethpandaops/ethereum-package#765))
([ad75fcc](ethpandaops/ethereum-package@ad75fcc))
* built in validator lifecycle test for assertoor
([ethereum#763](ethpandaops/ethereum-package#763))
([6f868cc](ethpandaops/ethereum-package@6f868cc))
* explicitly set client contexts
([ethereum#755](ethpandaops/ethereum-package#755))
([94dc531](ethpandaops/ethereum-package@94dc531))
* no default resource limits
([ethereum#768](ethpandaops/ethereum-package#768))
([4c4831b](ethpandaops/ethereum-package@4c4831b))
* prysm gRPC removal - use http server instead for keymanager
([ethereum#761](ethpandaops/ethereum-package#761))
([ba91174](ethpandaops/ethereum-package@ba91174))
* remove epoch checker for goomy
([ethereum#754](ethpandaops/ethereum-package#754))
([f124bbf](ethpandaops/ethereum-package@f124bbf))
* remove exp RPC API namespace flag from nimbus-eth1 configuration
([ethereum#767](ethpandaops/ethereum-package#767))
([8fec454](ethpandaops/ethereum-package@8fec454))
* reth-builder volume claim
([ethereum#771](ethpandaops/ethereum-package#771))
([4570328](ethpandaops/ethereum-package@4570328))
* update dora config for latest release & remove custom images
([ethereum#748](ethpandaops/ethereum-package#748))
([a433c50](ethpandaops/ethereum-package@a433c50))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet