eth/tracers/js: add coinbase addr to ctx #30231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
approved these changes
Aug 1, 2024
|
@lightclient what is required for this PR to be merged? |
|
Since it is a change to tracing, I would prefer to get an approval from @s1na before merging. |
|
@s1na would you be able to review this before merging? |
holiman
reviewed
Aug 15, 2024
| @@ -154,6 +154,9 @@ func TestTracer(t *testing.T) { | |||
| want: "", | |||
| fail: "reached limit for padding memory slice: 1049568 at step (<eval>:1:83(20)) in server-side tracer function 'step'", | |||
| contract: []byte{byte(vm.PUSH1), byte(0xff), byte(vm.PUSH1), byte(0x00), byte(vm.MSTORE8), byte(vm.STOP)}, | |||
| }, { // tests ctx.coinbase | |||
| code: "{lengths: [], step: function(log) { }, fault: function() {}, result: function(ctx) { var coinbase = ctx.coinbase; return toAddress(coinbase); }}", | |||
| want: `{"0":0,"1":0,"2":0,"3":0,"4":0,"5":0,"6":0,"7":0,"8":0,"9":0,"10":0,"11":0,"12":0,"13":0,"14":0,"15":0,"16":0,"17":0,"18":0,"19":0}`, | |||
There was a problem hiding this comment.
I don't get it. What is this mapping? How does this correspond to return toAddress(coinbase); ?
There was a problem hiding this comment.
The mapping seems to be "string index" -> decimal value of byte at index. It's weird. But that's how the other tracer tests work.
It maps to the default coinbase of 0x0. We could change it to a non-zero value, but I don't see much benefit. If this PR isn't working correctly, it will return nothing (bc no ctx value for coinbase).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coinbase address to javascript tracer context.
This PR adds the
coinbaseaddress tojsTracer.ctx, allowing access to the coinbase address (fee receipient) in custom JavaScript tracers.Example usage:
This change enables custom tracers to access coinbase address, previously unavailable, enhancing their capabilities to match built-in tracers.