cmd/evm: fix random in runtime config #29896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lyfsn <dev.wangyu@proton.me>
karalabe
reviewed
May 31, 2024
| @@ -227,6 +227,7 @@ func runCmd(ctx *cli.Context) error { | |||
| EVMConfig: vm.Config{ | |||
| Tracer: tracer, | |||
| }, | |||
| Random: &genesisConfig.Mixhash, | |||
There was a problem hiding this comment.
Hmmm, any particular reason for picking Mixhash to init the random field with?
There was a problem hiding this comment.
Sorry, no particular reason. I just see there are two fields in the genesis config, Mixhash and ParentHash. Their type is common.Hash, the same as Random. Any suggestions about which field should be used?
|
Afaik this was fixed in #29799. Do you have a "repro" showing this not to be fixed? |
Sure, it's my mistake. This problem is actually fixed. Since it's not the release version, I missed testing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the EVM command will never enter the fork version after London.
This is due to the commit in v1.13.13: https://github.com/ethereum/go-ethereum/pull/29023/files