metrics/librato: fix incorrect calculation of sumSquares #29621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log.Printf("WARNING: This client has been DEPRECATED! It has been moved to https://github.com/mihasya/go-metrics-librato and will be removed from rcrowley/go-metrics on August 5th 2015")Heh, this code was deprecated before we vendored it. Perhaps we should just nuke this file ? |
|
You mean delete all files related to librato and edit README, right? |
|
Myeah, we have Influx and Prometheus and that's already a huge pain due to incompatible feature sets. We really don't want yet another mertics reporting endpoint. I'd even venture to say we should remove expvar from Go's debug server. |
|
I make a PR #29624 to remove librato. Please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the wikipedia link, https://en.wikipedia.org/wiki/Standard_deviation#Rapid_calculation_methods
should be