Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move tx indexer to its own file #28857

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

rjl493456442
Copy link
Member

This pull request moves all the transaction indexing functions to a separate txindexer.go file and define a txIndexer structure as a refactoring.

For reviewers, the core functions(indexing/unindexing) are not changed, just the refactor.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman
Copy link
Contributor

holiman commented Jan 23, 2024

linter complains

core/txindexer.go:220:2: S1023: redundant `return` statement (gosimple)
	return

@holiman holiman added this to the 1.13.11 milestone Jan 23, 2024
@holiman
Copy link
Contributor

holiman commented Jan 23, 2024

--- FAIL: TestEthClient (0.14s)
    --- FAIL: TestEthClient/StatusFunctions (0.00s)
        ethclient_test.go:481: unexpected progress: &{0 2 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0}
FAIL

???

@holiman holiman merged commit 6b0de79 into ethereum:master Jan 23, 2024
1 of 3 checks passed
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
This change moves all the transaction indexing functions to a separate txindexer.go file and defines a txIndexer structure as a refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants