core: fix genesis setup in benchReadChain #28856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
requested review from
karalabe,
holiman and
rjl493456442
as code owners
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, currently the benchmarks
BenchmarkChainRead_header_10ketc are failing with:error creating chain: database contains incompatible genesis (have c27db71b33e259aa7357e6d44f8f1c78adbae50d5ac59d61103ec0f1ad109a3f, new d4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3I made this change to call
&core.Genesis{}.ToBlock().Header()to set-up the genesis header, since the amount of setup in the test is not sufficient to pass through the checks inSetupGenesisBlockAlternatively, we could set the loop to start at 1 here for a less invasive change and similar effect, if you prefer.