Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oss-fuzz: update fuzzers to native go fuzzing #28352

Merged
merged 13 commits into from
Oct 18, 2023

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Oct 16, 2023

This PR modifies the fuzzers to use native golang fuzzing instead of go-fuzz

@holiman
Copy link
Contributor

holiman commented Oct 16, 2023

Posting what I wrote earlier from discord

I'm thinking that it's two parts really: one pretty simple part of just converting from go-fuzz entrypoints to testing.F entry-points, and another more complicated task of the whole oss-fuzz integration.

And we should really consider if not the fuzzers should be moved from tests/fuzzers/x back into the core codebase.

Previously it made sense to have them separate, because then their go-fuzz import didn't affect the main go.mod, and also the files were excluded from builds, and not part of the public packages. But now that we can put them in _test files, that's not a concern. And having them alongside regular tests and benchmarks make sense, not least since they can reuse many of the same methods.

So I think we should move them. But before we do that, we should figure out if that makes oss-fuzz integration more complicated

@holiman
Copy link
Contributor

holiman commented Oct 17, 2023

Ooh, nice badge:

Fuzzing Status

@MariusVanDerWijden
Copy link
Member Author

Okay the build should be fixed now. I thought we should do this in a two step process:
(1) update the fuzzers to native fuzzing and update oss-fuzz for that
(2) modify the fuzzers to take better advantage of native fuzzing and move them to the package they belong
This PR only addresses (1), but I think its easiest to tackle (2) in a follow-up pr

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough IMO

@holiman holiman added this to the 1.13.5 milestone Oct 18, 2023
@holiman holiman merged commit d10a2f6 into ethereum:master Oct 18, 2023
1 check passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
…eum#28352)

This change modifies the fuzzers to use the native golang fuzzing framework instead of go-fuzz
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
…eum#28352)

This change modifies the fuzzers to use the native golang fuzzing framework instead of go-fuzz
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 29, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 4, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants