-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oss-fuzz: update fuzzers to native go fuzzing #28352
Conversation
Posting what I wrote earlier from discord I'm thinking that it's two parts really: one pretty simple part of just converting from go-fuzz entrypoints to testing.F entry-points, and another more complicated task of the whole oss-fuzz integration. And we should really consider if not the fuzzers should be moved from tests/fuzzers/x back into the core codebase. Previously it made sense to have them separate, because then their go-fuzz import didn't affect the main go.mod, and also the files were excluded from builds, and not part of the public packages. But now that we can put them in _test files, that's not a concern. And having them alongside regular tests and benchmarks make sense, not least since they can reuse many of the same methods. So I think we should move them. But before we do that, we should figure out if that makes oss-fuzz integration more complicated |
Okay the build should be fixed now. I thought we should do this in a two step process: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough IMO
…eum#28352) This change modifies the fuzzers to use the native golang fuzzing framework instead of go-fuzz
ethereum#28352)" This reverts commit e88c671.
ethereum#28352)" This reverts commit e88c671.
…eum#28352) This change modifies the fuzzers to use the native golang fuzzing framework instead of go-fuzz
This PR modifies the fuzzers to use native golang fuzzing instead of go-fuzz