Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add support for enabling metrics from env vars #28118

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

karalabe
Copy link
Member

This is another followup PR to fix corner cases in the env var support. The metrics subsystem completely ignores the CLI library and rather directly checks if --metrics or --metrics.expensive is specified in os.Args. It does this to ensure that my the time anything accesses metrics.Enabled, the field has been correctly initialized, even if it's accessed on package initializer methods.

This PR extends this part of the logic to also check for GETH_METRICS and GETH_METRICS_EXPENSIVE env vars in the same vein. A tad ugly for sure, but beats rethinking all the initialization logic.

@karalabe karalabe added this to the 1.13.1 milestone Sep 14, 2023
@karalabe karalabe merged commit 65a17c0 into ethereum:master Sep 14, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 13, 2024
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 16, 2024
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 16, 2024
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 20, 2024
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 20, 2024
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant