metrics: Synchronous EWMA #27918
Closed
metrics: Synchronous EWMA #27918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeim839
force-pushed
the
ewma_sync
branch
2 times, most recently
from
3a3971f to
c76c6cf
Compare
|
Hi, and thanks for your PR. With that change, this PR became very bitrotted. If you would like to rebase it on top of the changes, we can make another attempt at getting this PR in. Apologies for not getting to this sooner -- the |
|
No problem. I'm not sure if I'll have the time to look into this anytime soon, so I will be closing this PR for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #27846
Note:
Updating the EWMA every nanosecond would yield erratically inflated results, especially if Rate() was called immediately after EWMA initialization. I've thus opted for a 1-second interval (allowing uncounted events to accumulate) before updating the EWMA.
Previously, the StandardMeter struct held a snapshot that would be continuously updated by the Tick() function. Since metrics are no longer governed by a clock, I've reworked the Snapshot() function to create a new snapshot struct whenever it is called.