Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/ethapi: eth_simulateV1 #27720
internal/ethapi: eth_simulateV1 #27720
Changes from 114 commits
62d33d5
80df50d
c3f1494
a219206
0285f81
c301ce4
922f72c
80bcb16
4478f20
2ae2fe5
0aaaf34
2db37b9
04965a3
c78330d
8fff7fd
637acc5
d23eb89
a7af5a9
98882fc
b865824
da3102e
6a2c96c
b3efbad
9aed710
2c25ab6
5d351c9
63f4f6e
80506ea
fd786c0
6845b5e
c5e33fa
d4e332e
b0e7869
56b4402
7e17e4c
fe3bb83
906d93a
8e02675
a0d2706
ed4cbaf
3231291
3df0fec
760f5e5
b3996e4
100c593
523e3d2
d5c0ff4
45ba37e
973116c
a5ffd9a
cc1158a
2690445
d1ce690
e230258
c02d29d
e4eb56a
ed37821
f5ac039
23ef9c6
6da9202
12d59b5
1616559
7fff1c4
bf78094
c594f74
11133e0
ad24d2e
c77da8c
3d29c1f
31e2cc9
5ed9958
2b1cf22
fd0f626
1e7b497
589107b
89df0e3
1a28a17
115117c
df14718
ae33566
12d7dd0
214e209
af155c1
c73c10a
489ef43
0c0b13d
86ce924
4a017ff
49bf257
9fa1556
7177f22
3daabda
c08ba25
81e7fe1
8698221
48ca188
81e065c
263cfd7
e382782
9139685
569a2d7
d7cd3a0
399812a
1c154e9
638d82b
ac690f0
a9842e5
a6f80c7
5db0106
4c325ba
102aa80
172ed02
ddba7dd
c0d5dfb
e3cd999
33400fb
5f0fafd
73ff7e5
5d8c058
edf9e37
e7bac20
9a963dc
7198fc1
6ec5083
791719a
c216ef5
2415110
6205806
098a448
9da10f9
f25fcd3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, please rename it to
SkipFromEOACheck
btw, do you know in which scenario this field/feature will be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right should be EOA definitely 👍
This is used when simulating in validation mode. In validation mode we want everything to be checked but only relax the requirement of the sender to be an EOA, e.g. to still allow calling from a multisig contract.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to remove this part of code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not removed but moved to the API layer. It will cause some duplication of code but I believe it's more correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not renaming the fields to FeeRecipient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean in the
override
type? Happy to do that but changing theBlockOverrides
type would be a breaking change so would prefer to avoid that.