miner: initialize maps with known size #27228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
changed the title
holiman
reviewed
May 8, 2023
miner/worker.go
Outdated
| @@ -121,7 +121,7 @@ func (env *environment) copy() *environment { | |||
| // to do the expensive deep copy for them. | |||
| cpy.txs = make([]*types.Transaction, len(env.txs)) | |||
| copy(cpy.txs, env.txs) | |||
| cpy.uncles = make(map[common.Hash]*types.Header) | |||
| cpy.uncles = make(map[common.Hash]*types.Header, len(env.uncles)) | |||
There was a problem hiding this comment.
This change conflicts with https://github.com/ethereum/go-ethereum/pull/27218/files#diff-689874b30f6f905ce6c47cdefeddcf052b467a7936a981f4b6cf38939e10d924L124, where @rjl493456442 removes it. Let's revert this change and leave it be as is, it won't be present for much longer anyway
miner/payload_building_test.go
Outdated
| @@ -82,7 +82,7 @@ func TestBuildPayload(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestPayloadId(t *testing.T) { | |||
| ids := make(map[string]int) | |||
| ids := make(map[string]int, 7) | |||
There was a problem hiding this comment.
IMO micro-optimizations inside tests isn't worth it. I'd rather not touch it personally
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
* miner : initialize maps with known size * miner:some reverts
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* miner : initialize maps with known size * miner:some reverts
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 182fc72.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 182fc72.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.