Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: refactor txpool into it's own package in prep for 4844 #26038

Merged
merged 1 commit into from
Oct 24, 2022
Merged

all: refactor txpool into it's own package in prep for 4844 #26038

merged 1 commit into from
Oct 24, 2022

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Oct 24, 2022 •
edited
Loading

This PR should be a NOOP refactor, moving the tx pool into its own package. The goal is to reduce the surface of the core package a bit and lay the groundwork for the 4844 second txpool to be added beside the legacy one. This PR should also help keep a future txpool rewrite more scoped.

@karalabe karalabe added this to the 1.11.0 milestone Oct 24, 2022
holiman
holiman approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green

@karalabe karalabe merged commit a2b7481 into ethereum:master Oct 24, 2022
@gzliudan gzliudan mentioned this pull request May 17, 2024
Open
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
b96ed02 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
4194416 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
8b0bd9a 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
b0fd17e 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
e56c3ee 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
a20d5c0 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
0186a5e 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
f13391f 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
29e3d37 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
b774e3e 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
3d7c33d 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
50ab30b 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
cb7481d 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
ca958e7 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
7911108 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
bea3e3f 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
158d158 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
33cd7b6 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
3a64e77 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
34fdb0e 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
409f264 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
0aa5320 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
289f365 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
6c7b8a2 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
80b12b1 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
72ca1ca 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
0e484cf 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
8f10506 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
f8d8ac7 
…#26038)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
all: refactor txpool into it's own package in prep for 4844 (ethereum…
f156ec5 
…#26038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@karalabe @holiman