core/state/snapshot: remove noop map item assignment #24659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
approved these changes
Apr 7, 2022
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Apr 12, 2022
core/state/snapshot: remove noop map item assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line is not necessary, it reassigned an entry to a map, but that entry originated from the same map. I think this "noop" line originated from a previous code where the entry was a slice. However, if the entry being retrieved and reassigned is a map, that is a pointer internally in Go, so modifying it does not change the outer structure, thus no need for the reassignment.