core/rawdb: fix db commands #24540
Merged
core/rawdb: fix db commands #24540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Mar 15, 2022
| // will suddenly break lots of database relevant commands. So the metadata file | ||
| // is always opened for mutation and nothing else will be written except | ||
| // the initialization. | ||
| meta, err = openFreezerFileForAppend(filepath.Join(path, fmt.Sprintf("%s.meta", name))) | ||
| if err != nil { |
There was a problem hiding this comment.
Isn't it easier to just check os.IsNotExist(err) and ignore it here?
There was a problem hiding this comment.
In this case, the meta file handler is nil and we need to check if the handler is nil afterward.
There was a problem hiding this comment.
I think the hack is acceptable
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 23, 2022
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hack to freezer, the newly introduced meta data file will always be opened in the read/write mode.
The reason for adding this hack is: the meta data files are missing for legacy nodes which means most of the db commands will fail when the db is opened in the read-only mode.
Since tail deletion is not used right now, the only mutation can be made is initialization which is acceptable instead of breaking existent commands.