rpc: fix defer in test

[s7v7nislands]

No description provided.

[holiman]

Another way to fix this would have been to just move the defer conn.Close() to here, like this:

         n, err := conn.Read(buf)
         conn.Close()
         if err != nil{ 
               ...

I don't really have an opinion. Your way works too. Any other opinions? cc @fjl

[fjl]

Yes, I'd prefer that too (moving the close after read).

I also think the defer in loop is not a big deal here. It's a unit test, and the loop has a constant number of iterations.

[holiman]

quirky:

--- FAIL: TestClientWebsocketPing (0.00s)
    websocket_test.go:315: can't listen: listen tcp 127.0.0.1:0: socket: An operation was attempted on something that is not a socket.
--- FAIL: TestClientWebsocketSevered (0.00s)
    websocket_test.go:315: can't listen: listen tcp 127.0.0.1:0: socket: An operation was attempted on something that is not a socket.
--- FAIL: TestWebsocketLargeCall (0.00s)
panic: httptest: failed to listen on a port: listen tcp6 [::1]:0: socket: An operation was attempted on something that is not a socket. [recovered]
	panic: httptest: failed to listen on a port: listen tcp6 [::1]:0: socket: An operation was attempted on something that is not a socket.

[fjl]

Yeah, very interesting behavior there. Looks like a Go runtime issue? Maybe CloseWrite + Close leads to fd confusion in runtime.

[holiman]

Yeah, but still, the change concerns TestServerShortLivedConn, not any of the tests that failed.

[holiman]

https://support.microsoft.com/en-us/topic/7b064553-5332-b525-2dd4-4e123f9f7f23

This behavior may occur if the WinSocks library or the TCP/IP stack are corrupted.

Yikes :)

[holiman]

I've restarted the build, maybe it was just a random error