crypto/bn256/cloudflare: fix asm for dynamic linking #24476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when dynamic linking, R15 is clobbered by a global variable access and is used here; avoid them. Fixes: ethereum#24439
Zachinquarantine
approved these changes
Feb 28, 2022
|
This should be fixed upstream first in https://github.com/cloudflare/bn256. We can pull the changes afterwards, but it's important to keep it consistent with upstream. |
|
Sent pull request to upstream repository. |
|
Pull request of upstream was merged. Can merge this pull request? |
|
I can confirm this change matches the change submitted upstream. |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Mar 9, 2022
When using -buildmode=shared, R15 is clobbered by a global variable access; use a different register instead. Fixes: ethereum#24439
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
When using -buildmode=shared, R15 is clobbered by a global variable access; use a different register instead. Fixes: ethereum#24439
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
When using -buildmode=shared, R15 is clobbered by a global variable access; use a different register instead. Fixes: ethereum#24439
wgr523
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jan 18, 2024
When using -buildmode=shared, R15 is clobbered by a global variable access; use a different register instead. Fixes: ethereum#24439
19 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when dynamic linking, R15 is clobbered by a global variable access and is used here; avoid them.(go1.17~)
refs
Fixes: #24439