internal/build: switch azure sdk from Azure/azure-storage-blob-go to Azure/azure-sdk-for-go/sdk/storage/azblob. #24473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0. relation ethereum#24396.
fix for breaking changes of update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0. relation ethereum#24396.
uji
changed the title
|
Thanks for the PR! Reading up a bit on the Azure SDK's though, it seems that https://github.com/Azure/azure-storage-blob-go has been deprecated last year and everyone is advised to switch to https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/storage/azblob. Perhaps it would be wiser to do the jump in one go rather than switching to a version we know is not supported any more. |
…Azure/azure-sdk-for-go/sdk/storage/azblob.
uji
force-pushed
the
azure-storage-blob-go@v0.14.0
branch
from
130d742 to
60e1166
Compare
uji
changed the title
|
@karalabe |
|
Fixed some panics due to missing container ID from the URL (previously there were set in dedicated function calls which you removed). LGTM |
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
…Azure/azure-sdk-for-go/sdk/storage/azblob. (ethereum#24473) * go.mod: update azure-storage-blob-go update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0. relation ethereum#24396. * internal/build: fix for breaking changes of azure-storage-blob-go fix for breaking changes of update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0. relation ethereum#24396. * internal/build: switch azure sdk from Azure/azure-storage-blob-go to Azure/azure-sdk-for-go/sdk/storage/azblob. * internal/build refactor appending BlobItems * internal/build: fix azure blobstore client to include container id Co-authored-by: Péter Szilágyi <peterke@gmail.com>
cp-wjhan
pushed a commit
to cp-yoonjin/go-wemix
that referenced
this pull request
Nov 16, 2022
…Azure/azure-sdk-for-go/sdk/storage/azblob. (ethereum#24473) * go.mod: update azure-storage-blob-go update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0. relation ethereum#24396. * internal/build: fix for breaking changes of azure-storage-blob-go fix for breaking changes of update Azure/azure-storage-blob-go from v0.7.0 to v0.14.0. relation ethereum#24396. * internal/build: switch azure sdk from Azure/azure-storage-blob-go to Azure/azure-sdk-for-go/sdk/storage/azblob. * internal/build refactor appending BlobItems * internal/build: fix azure blobstore client to include container id Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated Azure/azure-storage-blob-go from v0.7.0 to v0.14.0(latest version).
executed following command.
and then, fixed for breaking changes of Azure/azure-storage-blob-go.
relation #24396.