internal/ethapi: EstimateGas should use LatestBlockNumber by default #24363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes,why this code had not merge into master? |
|
I think this really problem, should use LatestBlockNumber rather than PendingBlockNumber can avoid error. |
Reopened to hear the advice of the official team :) |
|
if use pendingblocknumber,then in code: |
rjl493456442
approved these changes
May 11, 2023
shekhirin
pushed a commit
to shekhirin/go-ethereum
that referenced
this pull request
Jun 6, 2023
…reum#24363) * EstimateGas should use LatestBlockNumber by default * graphql: default to use latest for gas estimation --------- Co-authored-by: Martin Holst Swende <martin@swende.se>
DarianShawn
pushed a commit
to dogechain-lab/dbsc
that referenced
this pull request
Sep 3, 2023
…20) ### Description upstream PR: [go-ethereum#24363](ethereum/go-ethereum#24363) We met a problem that if the `args TransactionArgs` depends on the latest committed block N, `PendingBlockNumber` is still N-1, which causes the estimation to fail. `LatestBlockNumber` is a better default value IMO. ethereum/go-ethereum#24363 (comment) : ``` if use pendingblocknumber,then in code: block, err := b.BlockByNumberOrHash(ctx, blockNrOrHash) you may get error or "block not found". ```
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#24363) * EstimateGas should use LatestBlockNumber by default * graphql: default to use latest for gas estimation --------- Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…lt (ethereum#24363)" This reverts commit 4f615de.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…lt (ethereum#24363)" This reverts commit 4f615de.
MariusVanDerWijden
pushed a commit
that referenced
this pull request
Mar 18, 2025
…c block (#27508) The main use case I see of this is that it allows users to estimate gas against the same state that they query for their nonce, and the same state they base the data of their transaction against. This helps ensure that gas estimation won't fail and the transaction won't revert on-chain because of a mismatch between the state used for gas estimation and the state used to generate the inputs to gas estimation or the transaction's nonce when submitted to the mempool. This PR also updates the EstimateGas comment based on the new geth `eth_estimateGas` default of using latest state as of v1.12.0: #24363 --------- Co-authored-by: Felix Lange <fjl@twurst.com>
sivaratrisrinivas
pushed a commit
to sivaratrisrinivas/go-ethereum
that referenced
this pull request
Apr 21, 2025
…c block (ethereum#27508) The main use case I see of this is that it allows users to estimate gas against the same state that they query for their nonce, and the same state they base the data of their transaction against. This helps ensure that gas estimation won't fail and the transaction won't revert on-chain because of a mismatch between the state used for gas estimation and the state used to generate the inputs to gas estimation or the transaction's nonce when submitted to the mempool. This PR also updates the EstimateGas comment based on the new geth `eth_estimateGas` default of using latest state as of v1.12.0: ethereum#24363 --------- Co-authored-by: Felix Lange <fjl@twurst.com>
buddh0
pushed a commit
to buddh0/bsc
that referenced
this pull request
Apr 24, 2025
…c block (#27508) The main use case I see of this is that it allows users to estimate gas against the same state that they query for their nonce, and the same state they base the data of their transaction against. This helps ensure that gas estimation won't fail and the transaction won't revert on-chain because of a mismatch between the state used for gas estimation and the state used to generate the inputs to gas estimation or the transaction's nonce when submitted to the mempool. This PR also updates the EstimateGas comment based on the new geth `eth_estimateGas` default of using latest state as of v1.12.0: ethereum/go-ethereum#24363 --------- Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We met a problem that if the
args TransactionArgsdepends on the latest committed blockN,PendingBlockNumberis stillN-1, which causes the estimation to fail.LatestBlockNumberis a better default value IMO.