core: periodically flush the transaction indexes #24197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to run the snap sync benchmark to see the performance difference. |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 12, 2022
…h-batch core: periodically flush the transaction indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out memory allocation is really inefficient in goleveldb batch. Constructing a large batch will take a few seconds and most of the time is spent on memory allocation.
During the chain sync we noticed transaction indexing is expensive, one big cost is constructing a large batch for indexes. Therefore in this PR the single huge batch is divided into several small one according to the ideal batch size.