cmd/geth: add tests for version_check #24169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rangzen
force-pushed
the
add-tests-cmd-version_check
branch
from
2712ee3
to
3f0aded
Compare
TestGethPubKeysParseable is inspired by the comment in cmd/geth/version_check.go:141: "our pubkeys should be parseable". TestKeyID checks the minisign public key of each gethPubKeys.
rangzen
force-pushed
the
add-tests-cmd-version_check
branch
from
3f0aded
to
c2dac1f
Compare
holiman
approved these changes
Jan 11, 2022
|
Thanks! |
sidhujag
pushed a commit
to syscoin/go-ethereum
that referenced
this pull request
Jan 12, 2022
JacekGlen
pushed a commit
to JacekGlen/go-ethereum
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestGethPubKeysParseable is inspired by the comment
in cmd/geth/version_check.go:141: "our pubkeys should be parseable".
TestKeyID checks the minisign public key of each gethPubKeys.