-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clique: fix block number unmarshal #23961
Conversation
consensus/clique/api.go
Outdated
@@ -196,7 +196,11 @@ func (sb *blockNumberOrHashOrRLP) UnmarshalJSON(data []byte) error { | |||
if err := json.Unmarshal(data, &input); err != nil { | |||
return err | |||
} | |||
sb.RLP = hexutil.MustDecode(input) | |||
unhexed, err := hexutil.Decode(input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please call it blob
:) We use it throughout the code when referring to a decoded binary... blob :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Missed opportunity to call it bob
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* clique: fix block number unmarshal * clique: rename
* clique: fix block number unmarshal * clique: rename
Doing
clique.getSigner('00ff')
(hex string without0x
) in the console caused a crash