Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm: fix incorrect default value for trace.nomemory and trace.noreturndata #23933

Closed

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Nov 18, 2021

These should default to false since they're later inverted:

logConfig := &vm.LogConfig{
DisableStack: ctx.Bool(TraceDisableStackFlag.Name),
EnableMemory: !ctx.Bool(TraceDisableMemoryFlag.Name),
EnableReturnData: !ctx.Bool(TraceDisableReturnDataFlag.Name),
Debug: true,
}

@holiman
Copy link
Contributor

holiman commented Nov 19, 2021

BoolTFlag

BoolTFlag is a flag with type bool that is true by default

As opposed to a BoolFlag, which is false by default. So right now, we disable memory output by default. The change you propose would make disable false by default, meaning it would be by default enabled. Which is not what we want, because in most cases memory output is too large to work with.

@simonshampoo
Copy link

so how do we enable memory output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants