Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/types: copy tx recipient address #23376

Merged
merged 6 commits into from
Oct 6, 2021
Merged

core/types: copy tx recipient address #23376

merged 6 commits into from
Oct 6, 2021

Conversation

aaronbuchwald
Copy link
Contributor

This PR creates a helper function CopyAddress to copy address pointers and uses it to address an outstanding TODO related to copying To addresses in transactions.

@aaronbuchwald
Copy link
Contributor Author

Wondering if it's cleaner to add a function common.CopyAddress(addr) instead

holiman
holiman reviewed Aug 11, 2021
View reviewed changes
common/types.go Outdated Show resolved Hide resolved
@fjl
Copy link
Contributor

fjl commented Sep 7, 2021

We have discussed this and would rather have the function to copy an address pointer in core/types. The method is too specialized to be useful.

@fjl fjl force-pushed the copy-pointed-to-addr branch from b60f145 to 939af88 Compare October 6, 2021 10:12
@fjl fjl changed the title Add helper for copying address pointers and address TODO core/types: copy tx recipient address Oct 6, 2021
@fjl fjl merged commit 4e599ee into ethereum:master Oct 6, 2021
@fjl fjl added this to the 1.10.10 milestone Oct 6, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Oct 6, 2021
@aaronbuchwald @fjl
core/types: copy tx recipient address (ethereum#23376)
ada31af 
This resolves a long-standing TODO. The point of copying the address is
to ensure that all data referenced by types.Transaction is independent of the
data passed into the constructor.

Co-authored-by: Felix Lange <fjl@twurst.com>
This was referenced Sep 23, 2022
Closed
Merged
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@aaronbuchwald @fjl @zzyalbert
core/types: copy tx recipient address (ethereum#23376)
5fd23a6 
This resolves a long-standing TODO. The point of copying the address is
to ensure that all data referenced by types.Transaction is independent of the
data passed into the constructor.

Co-authored-by: Felix Lange <fjl@twurst.com>
@gzliudan gzliudan mentioned this pull request Jun 11, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
a6d3a81
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
2c8f23c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
5d3df9d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
4c04d72
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
1360ec1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
9c4da62
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
76b7484
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
b3d73f4
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
87638ad
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
bafddfb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
3767632
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
b3ac547
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
f084826
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
fc5cf6b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
5074196
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
6bf58f0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
2545f79
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
d8b0b57
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
9cf7038
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
30f17f3
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
c03970f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
912e6b9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
edd4dec
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
eb8d0a0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
6d9f0b8
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
91c5ba9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
62b10cf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
077aabc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
core/types: copy tx recipient address (ethereum#23376)
17b6231
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@gzliudan @wanwiset25
core/types: copy tx recipient address (ethereum#23376)
8352744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman left review comments

@karalabe karalabe Awaiting requested review from karalabe

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.10
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronbuchwald @fjl @holiman @ligi