Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/abi/bind: check event signature before parsing #23230

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

yihau
Copy link
Contributor

@yihau yihau commented Jul 18, 2021

I open this PR for issue#23153
I make UnpackLog and UnpackLogIntoMap check event signature first.
It will return error if event signature mismatch.

closes #23153

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks, otherwise LGTM!

@yihau
Copy link
Contributor Author

yihau commented Aug 10, 2021

Hey, is there any news on this?

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@yihau
Copy link
Contributor Author

yihau commented Aug 20, 2021

Hi @gballet , would you mind take a look at this? Thank you!

@MariusVanDerWijden
Copy link
Member

@yihau We'll merge this after our next release on tuesday.

@holiman holiman merged commit 92c5d10 into ethereum:master Sep 28, 2021
@holiman holiman added this to the 1.10.9 milestone Sep 28, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Sep 28, 2021
* accounts/abi/bind: check event signature before parsing

* remove redundant break line
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
* accounts/abi/bind: check event signature before parsing

* remove redundant break line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should if add a topic[0] checking to UnpackLog/UnpackLogIntoMap ?
4 participants