-
Notifications
You must be signed in to change notification settings - Fork 20.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: add change counter #23095
core: add change counter #23095
Conversation
core/tx_pool.go
Outdated
@@ -111,6 +111,7 @@ var ( | |||
invalidTxMeter = metrics.NewRegisteredMeter("txpool/invalid", nil) | |||
underpricedTxMeter = metrics.NewRegisteredMeter("txpool/underpriced", nil) | |||
overflowedTxMeter = metrics.NewRegisteredMeter("txpool/overflowed", nil) | |||
throttleTxMeter = metrics.NewRegisteredMeter("txpool/throttle", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a meter for the reorgs, then we could see how wildly we're spinning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a few more metrics there too: how long reorgs take (timer), how many drops in between reorgs (hist), + whatnot the author wants :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should push this in right after the 1.10.5 release.
7a5544e
to
3905561
Compare
This is now running on eu-west-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
This PR adds a change-counter, to prevent too much from happening inside the pool before the pool has had a chance to run a reorg, which 'balances' the queued and pending transactions.