EIP-1559 tx pool support #22898
EIP-1559 tx pool support #22898
Conversation
zsfelfoldi
requested review from
holiman,
karalabe and
rjl493456442
as code owners
zsfelfoldi
force-pushed
the
eip1559-mempool
branch
2 times, most recently
from
5cb5e6c to
c604a47
Compare
core/tx_list.go
Outdated
There was a problem hiding this comment.
In this strategy, we can only replace the transaction with 10% feeCap bump and 10% tip bump. It might hurt the UX to some extent.
For example, if the user already specify a high enough feeCap but a barely enough tip. And he wants to speed up the inclusion, he has to bump the feeCap as well. If the basefee raises up, then the maximum possible payment is increased.
There was a problem hiding this comment.
This has been discussed at the 1559 dev channel, right now this replacement condition seems to be the best choice.
|
Rebased + fixed rebase problems |
|
|
zsfelfoldi
force-pushed
the
eip1559-mempool
branch
from
2b9701f to
3df30d8
Compare
|
This is now running on |
* replace GasPriceCmp and GasPriceIntCmp with FeeCapCmp, FeeCapIntCmp, TipCmp, TipIntCmp (and update all usages) * update Cost to use FeeCap instead of GasPrice
* add eip1559 status indicator * add DynamicFeeTx to transaction type check * remove underpriced transactions on minimum miner tip increases * require both a fee cap and tip bump for transaction replacement * use tip as secondary comparison criterion for priceHeap sorting
…transaction validation
…e post-EIP-1559 arm of pool.SetMinMinerFee()
8 participants
This pull request implements EIP-1559 compatible transaction pool with dual heap eviction ordering.
It is based on #22791
The eviction ordering scheme and the reasoning behind it is described here: https://gist.github.com/zsfelfoldi/9607ad248707a925b701f49787904fd6