p2p/nat: skip TestUPNP in non-CI envs if discover fails #22877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethereum#21476 Date: 2021-05-13 12:33:01-05:00 Signed-off-by: meows <b5c6@protonmail.com>
|
Thanks! |
atif-konasl
pushed a commit
to frozeman/pandora-execution-engine
that referenced
this pull request
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue from #21476.
This issue is pretty annoying for me; I don't want to accept failure as the normal development test status.
This proposed patch causes the offending test to
Skipif it would otherwise fail and the environment has an emptyCIenv var value (suggesting the environment is not CI). As far as I know, all CI environments set this value, eg:CI=true)CI=true)