Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: single end logging in json logger #22825

Merged
merged 1 commit into from
May 6, 2021

Conversation

JekaMas
Copy link
Contributor

@JekaMas JekaMas commented May 5, 2021

While trying FuzzyVM on the recent go-ethereum master (37b5595456e7049e3ed487c41564281de52e00ab) I got an incorrect output.

Got:

./evm --json --nomemory statetest ~/github.com/MariusVanDerWijden/FuzzyVM/interesting_inputs/BenchTest-16.json
{"pc":0,"op":127,"gas":"0xb6c2b8","gasCost":"0x3","memory":"0x","memSize":0,"stack":[],"returnStack":null,"returnData":"0x","depth":1,"refund":0,"opName":"PUSH32","error":""}
{"pc":33,"op":99,"gas":"0xb6c2b5","gasCost":"0x3","memory":"0x","memSize":0,"stack":["0x564b34a33ecd1af05fe6923d6de71870997d38ef60155c325957214c4259d74b"],"returnStack":null,"returnData":"0x","depth":1,"refund":0,"opName":"PUSH4","error":""}
{"pc":38,"op":82,"gas":"0xb6c2b2","gasCost":"0x4268fec1b10","memory":"0x","memSize":0,"stack":["0x564b34a33ecd1af05fe6923d6de71870997d38ef60155c325957214c4259d74b","0x5c325957"],"returnStack":null,"returnData":"0x","depth":1,"refund":0,"opName":"MSTORE","error":"out of gas"}
{"output":"","gasUsed":"0xb6c2b8","time":180880,"error":"out of gas"}
{"output":"","gasUsed":"0xb6c2b8","time":180880}
{"stateRoot": "437973ecce685dc890492b71c035a103098a5dce5e4c42944dec7456a1ce564f"}
[
  {
    "name": "BenchTest-16",
    "pass": true,
    "fork": "Istanbul"
  }
]

Expected:

./evm --json --nomemory statetest ~/github.com/MariusVanDerWijden/FuzzyVM/interesting_inputs/BenchTest-16.json
{"pc":0,"op":127,"gas":"0xb6c2b8","gasCost":"0x3","memory":"0x","memSize":0,"stack":[],"returnStack":null,"returnData":"0x","depth":1,"refund":0,"opName":"PUSH32","error":""}
{"pc":33,"op":99,"gas":"0xb6c2b5","gasCost":"0x3","memory":"0x","memSize":0,"stack":["0x564b34a33ecd1af05fe6923d6de71870997d38ef60155c325957214c4259d74b"],"returnStack":null,"returnData":"0x","depth":1,"refund":0,"opName":"PUSH4","error":""}
{"pc":38,"op":82,"gas":"0xb6c2b2","gasCost":"0x4268fec1b10","memory":"0x","memSize":0,"stack":["0x564b34a33ecd1af05fe6923d6de71870997d38ef60155c325957214c4259d74b","0x5c325957"],"returnStack":null,"returnData":"0x","depth":1,"refund":0,"opName":"MSTORE","error":"out of gas"}
{"output":"","gasUsed":"0xb6c2b8","time":180880,"error":"out of gas"}
{"stateRoot": "437973ecce685dc890492b71c035a103098a5dce5e4c42944dec7456a1ce564f"}
[
  {
    "name": "BenchTest-16",
    "pass": true,
    "fork": "Istanbul"
  }
]

The second line in the output is redundant:

{"output":"","gasUsed":"0xb6c2b8","time":180880,"error":"out of gas"}
{"output":"","gasUsed":"0xb6c2b8","time":180880}

Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit df20b3b into ethereum:master May 6, 2021
@holiman holiman added this to the 1.10.4 milestone May 6, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants