Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/protocols/snap: use storage batch, not account batch in st task #22789

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

karalabe
Copy link
Member

When large contract sync was interrupted and resumed, recreating the task set the account batch into the storage trie stack tries, causing those to never be flushed, rather just pushed into until the contract completed.

@karalabe karalabe added this to the 1.10.3 milestone Apr 30, 2021
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe
Copy link
Member Author

Memory seems stable once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants